Skip to content

fix: tolerate null source import checksums#381

Draft
danshapiro wants to merge 1 commit into
kenn-io:mainfrom
danshapiro:codex/null-source-import-checksum
Draft

fix: tolerate null source import checksums#381
danshapiro wants to merge 1 commit into
kenn-io:mainfrom
danshapiro:codex/null-source-import-checksum

Conversation

@danshapiro

Copy link
Copy Markdown
Contributor

What changed

  • Scan source import item checksums through sql.NullString in GetSourceImportItem and ListImportedSourceItemChecksums.
  • Surface an empty checksum string when legacy/imported rows contain NULL.
  • Add focused store coverage for NULL checksum rows.

Why

Some source_import_items rows can have NULL checksum values, which previously caused scan errors when imported source items were read back.

Impact

Nullable checksums no longer break source import lookup or imported checksum listing; non-NULL checksum behavior is unchanged.

Validation

  • gofmt on touched Go files
  • go test -tags "fts5 sqlite_vec" ./internal/store
  • make testify-helper-check
  • go vet -tags "fts5 sqlite_vec" ./...

@roborev-ci

roborev-ci Bot commented Jun 13, 2026

Copy link
Copy Markdown

roborev: Combined Review (a9c82e7)

Verdict: No Medium, High, or Critical issues found.

The only reported finding was Low severity, so it is omitted per the review-combination rules.


Panel: ci_default_security | Synthesis: codex, 5s | Members: codex_default (codex/default, done, 1m51s), codex_security (codex/security, done, 12s) | Total: 2m8s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant