build(package update): update version of concurrently #34
Open
mdhitchcock wants to merge 2 commits intokentcdodds:mainfrom
Open
build(package update): update version of concurrently #34mdhitchcock wants to merge 2 commits intokentcdodds:mainfrom
mdhitchcock wants to merge 2 commits intokentcdodds:mainfrom
Conversation
added 2 commits
September 26, 2019 10:41
… 3.6.1 and to more current ^4.1 The version of concurrently that the current package.json locks in is old and has a couple serious bugs (https://github.com/kimmobrunfeldt/concurrently/issues/147 and https://github.com/kimmobrunfeldt/concurrently/issues/193). One effect is that any keystroke in a terminal running a package script using nps-utils will crash and leave processes running. This change is just to bump the version of concurrently from ^3.4.0 (which will install 3.6.1) to version ^4.1.0
…on of concurrently dependency The previous commit updated the version of concurrently because the version being used has serious bugs; but the change failed validation because the snapshot files needed to be updated to reflect the new file layout of the concurrently package
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 1
Lines ? 79
Branches ? 0
========================================
Hits ? 79
Misses ? 0
Partials ? 0 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update version of concurrently away from buggy 3.6.1 and to more current ^4.1
The version of concurrently that the current package.json locks in is old and has a couple serious
bugs (https://github.com/kimmobrunfeldt/concurrently/issues/147 and
https://github.com/kimmobrunfeldt/concurrently/issues/193). One effect is that any keystroke in a
terminal running a package script using nps-utils will crash and leave processes running. This
change is just to bump the version of concurrently from ^3.4.0 (which will install 3.6.1) to version
^4.1.0