fix:pass extractor constructor parameters to the base extractor#342
Open
vacavaca wants to merge 1 commit into
Open
fix:pass extractor constructor parameters to the base extractor#342vacavaca wants to merge 1 commit into
vacavaca wants to merge 1 commit into
Conversation
Fixes kepano#323 and would probably fix similar problems with other extractors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323 and would probably fix similar problems with other extractors.
Looks like it was just a minor compatibility issue. I found it when I was testing the cli against reddit and it broke with 403 despite me passing a customized
fetchto the options object.I mirrored how things were wired up in other extractor, built the project after my changes and tested it with reddit locally, everything works now. But I didn't test other extractors that I changed. Looking at the code and their constructor chains they are probably ok. @kepano FYI.