fix: network is bytes/s not bits/s #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small, localized change to CLI formatting logic with expanded unit tests; minimal risk beyond potential unit conversion/rounding differences in displayed values.
Overview
Fixes the
resourcesCLI output to correctly display network bandwidth limits in bits/sec (Kbps/Mbps/Gbps) by converting API-provided bytes/sec values (* 8) before formatting.Updates and expands
TestFormatBpsto reflect the bytes/sec input contract and adds coverage for common/edge bandwidth values, including the reported 30 Mbps regression case.Written by Cursor Bugbot for commit 0d15072. This will update automatically on new commits. Configure here.