Skip to content

Skip shared Firecracker standby compression#240

Draft
sjmiller609 wants to merge 1 commit into
mainfrom
hypeship/skip-shared-fc-compression
Draft

Skip shared Firecracker standby compression#240
sjmiller609 wants to merge 1 commit into
mainfrom
hypeship/skip-shared-fc-compression

Conversation

@sjmiller609
Copy link
Copy Markdown
Collaborator

@sjmiller609 sjmiller609 commented May 26, 2026

Summary

  • skip Firecracker standby snapshot compression when FIEMAP reports shared memory extents
  • keep compression enabled for non-shared files and non-Firecracker targets
  • add a low-cardinality reason label to snapshot compression job metrics so shared-extent skips are visible without changing disk utilization accounting
  • extend the Firecracker warm fork-chain integration test to inspect retained Firecracker snapshot bases for shared extents while preserving the existing fork-to-running and fork-again flow

Tests

  • go test ./lib/instances -run 'TestStartCompressionJobSkipsFirecrackerStandbySharedMemory|TestStartCompressionJobDoesNotSkipNonFirecrackerSharedMemory|TestSnapshotCompressionMetrics_RecordAndObserve|TestStartCompressionJobDelayedCancellationRecordsSkipped'
  • go test ./lib/forkvm ./lib/hypervisor/firecracker

@sjmiller609 sjmiller609 force-pushed the hypeship/skip-shared-fc-compression branch from 9eeada9 to d97e3e2 Compare May 26, 2026 15:25
@sjmiller609 sjmiller609 force-pushed the hypeship/skip-shared-fc-compression branch from d97e3e2 to 915f11e Compare May 26, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant