Fix warm fork guest MAC reconfiguration#245
Merged
Merged
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR modifies guest MAC reconfiguration logic in instances/hypervisor packages, not the API endpoints or Temporal workflows specified in the filter. To monitor this PR anyway, reply with |
sjmiller609
commented
May 27, 2026
rgarcia
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Note
Medium Risk
Changes standby-restore guest networking and MAC allocation; misconfiguration could break fork connectivity or cause MAC clashes, but scope is narrow and covered by new unit tests.
Overview
Warm standby fork restores now rebuild guest
eth0identity to match the new allocation, not only the snapshotted IP/route.Post-resume guest network setup is centralized in
guestNetworkReconfigureCommand, which validates IP/MAC/gateway/netmask, bringseth0down, sets the allocated MAC, flushes old IPv4 addresses, reapplies the fork IP and default route, brings the link up, and flushes neighbor cache.CreateAllocationnow picks MACs unused across existing allocations (random retries, then sequential scan in the02:00:00:…space), with unit tests for collision handling and the generated shell command.Reviewed by Cursor Bugbot for commit c4aba89. Bugbot is set up for automated code reviews on this repo. Configure here.