devices: qemu: add qemu-lava pass-through device#33
Open
bhcopeland wants to merge 2 commits into
Open
Conversation
roxell
requested changes
Jun 5, 2026
bhcopeland
force-pushed
the
qemu-lava
branch
2 times, most recently
from
553c8cd to
3445e96
Compare
Collaborator
|
I think commit kselftest: increase BPF timeout from 45 to 120 minutes was added here by mistake. |
Member
Author
Or I am checking you are reviewing properly =D. Removed thanks |
roxell
requested changes
Jun 5, 2026
Collaborator
|
Can we please update the commit messages? In commit "devices: add LAVADevice base..." you say something like, "and rebase fvp-lava onto it.", not sure its needed. maybe add "no functional changes"? and in commit "devices: qemu: add qemu-lava..." should say: "devices: lava: add qemu-lava..." |
Move the shared passthrough logic, load and validate a LAVA job definition and return it unchanged, into a new LAVADevice base in devices/lava.py. No functional changes. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
Add a qemu-lava device that submits a raw LAVA job definition unchanged, built on the shared LAVADevice base. Add unit tests for device selection, the missing-argument error, and passthrough of a sample QEMU job definition. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a QemuLAVA device that accepts a raw LAVA job definition via --job-definition and returns it unchanged, mirroring the existing fvp-lava device.
Add unit tests covering device selection, the missing-argument error, and pass-through of a sample QEMU job definition.