-
Notifications
You must be signed in to change notification settings - Fork 14
Wifi dongles and documentation fixes #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
When the shell is blocked on sleep, signal handlers don't execute until the command completes. This caused the script to ignore SIGTERM at shutdown, forcing Finit to wait and eventually SIGKILL it instead. Fix by running sleep in the background and using wait, which is interruptible by signals. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Simplify USB device debugging by allowing USB core to always announce details of every new USB device to syslog. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
When fdopen() succeeds, the FILE stream takes ownership of the file descriptor. Calling fclose() automatically closes the underlying fd, so the subsequent close(fd) calls were double-close bugs that could cause undefined behavior. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Extend the WiFi station mode with rx-speed and tx-speed leaves, mirroring what already exists for AP mode connected stations. Display bitrates in 'show interface <wifi>' detailed view. Also standardize speed units to kbps/Mbps across the YANG model. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Also, spruce up the table a bit. Allow it to resize, let the SSID column be flexible, and right-align column(s) with numbers. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
489b4f5 to
2b0174e
Compare
mattiaswal
requested changes
Jan 25, 2026
- Simplify, prefer readability - Fix nftw() 'nopenfd' argument - Constify The most interesting change is the argument to nftw(), 0 -> 20, to ensure it is allowed to open enough file descriptors to descend. In POSIX it is undefined if nopenfd is < 1. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
If we time out waiting for a wifi dongle, or onboard chipset, instead of causing fatal error in dagger and b0rking startup, we cheat and create a dummy interface. Also, fix bug in HEAD, the condition was == wifi_ap but the comment said "if not station or scanning mode". Since wpa_supplicant is for station mode (not AP), the cleanup should happen when != wifi_ap. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Ensure umask is properly managed around file creation to maintain consistent behavior across the codebase. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Reverse christmas tree. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
- Add missing SVG For dhcpv6 example - Fix link to static routes in WireGuard doc - Add WireGuard to a new VPN sub-section in nav bar Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The networking guide has grown out of control for quite some time, it is time to split it up into multiple files. This will hopefully also make it a bit more accessible to users. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
2b0174e to
68a638c
Compare
mattiaswal
approved these changes
Jan 25, 2026
Contributor
mattiaswal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code
kernel-upgrade.shextract-changelog.shscript for reflowing Markdown for releasesDocumentation
Inspired by the initial work done in
doc/firewall.md, I went ahead and generalized a new cli terminal output formatting style for examples. All (relevant) files have now been updated to this new example format.The
mkdocsbuild also complained about missing files, broken links, and unlinked documents. These have been addressed as well in this PR.The HUGE
doc/networking.mdhas been split into multiple documents for readability and maintainability. All intra-document links have been updated accordingly.Finally, the main
README.mdhas been given a bit of an update, much thanks to the the terminal output formatting style changes developed earlier.Checklist
Tick relevant boxes, this PR is-a or has-a: