Skip to content

confd: Wi-Fi: Set safe defaults #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattiaswal merged 2 commits into from
Jan 26, 2026
Merged

confd: Wi-Fi: Set safe defaults #1368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87737ff
confd: Wi-Fi: Set safe defaults
mattiaswal Jan 26, 2026
262b60c
workflow: build-image: Fix typo in bpi bootloader
mattiaswal Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
;;
bananapi-bpi-r3)
echo "BOOTLOADER_SD=bpi-r3-sd-boot" >> $GITHUB_ENV
echo "BOOTLOADER_EMMC=bpi-r3-emmc_boot" >> $GITHUB_ENV
echo "BOOTLOADER_EMMC=bpi-r3-emmc-boot" >> $GITHUB_ENV
echo "ARCH=aarch64" >> $GITHUB_ENV
echo "BUILD_EMMC=true" >> $GITHUB_ENV
;;
Expand Down
18 changes: 4 additions & 14 deletions src/confd/src/hardware.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,21 +272,9 @@ static void wifi_gen_ssid_config(FILE *hostapd, struct lyd_node *cif, struct lyd
/* Allow UTF-8 characters in SSID for international network names */
fprintf(hostapd, "utf8_ssid=1\n");

/* Use short preamble for better throughput on modern clients */
fprintf(hostapd, "preamble=1\n");

/* Disconnect clients with poor link quality to free up airtime */
fprintf(hostapd, "disassoc_low_ack=1\n");

/* Poll inactive clients before disconnecting to detect sleepy devices */
fprintf(hostapd, "skip_inactivity_poll=0\n");

/* Disable opportunistic key caching, reduces roaming attack surface */
fprintf(hostapd, "okc=0\n");

/* Disable PMKSA caching, forces fresh authentication for better security */
fprintf(hostapd, "disable_pmksa_caching=1\n");

security = lydx_get_child(ap, "security");
security_mode = lydx_get_cattr(security, "mode");

Expand Down Expand Up @@ -369,6 +357,9 @@ static void wifi_gen_radio_config(FILE *hostapd, struct lyd_node *radio_node)

fprintf(hostapd, "beacon_int=100\n");

/* Use short preamble for better throughput on modern clients */
fprintf(hostapd, "preamble=1\n");

if (band) {
if (!strcmp(band, "2.4GHz")) {
/* hw_mode=g: 2.4GHz with 802.11g (OFDM) as baseline */
Expand Down Expand Up @@ -440,8 +431,7 @@ static void wifi_gen_radio_config(FILE *hostapd, struct lyd_node *radio_node)
}
/* 802.11ax (WiFi 6) always enabled for better performance */
fprintf(hostapd, "ieee80211ax=1\n");
/* BSS coloring reduces interference in dense deployments */
fprintf(hostapd, "he_bss_color=1\n");

/* Beamforming improves signal quality and range */
fprintf(hostapd, "he_su_beamformer=1\n");
fprintf(hostapd, "he_su_beamformee=1\n");
Expand Down