Misc fixes #1371
Merged
Misc fixes #1371
+80
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troglobit
approved these changes
Jan 26, 2026
Contributor
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Nice, only a minor question.
troglobit
approved these changes
Jan 26, 2026
Contributor
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Heh, we're definitely in the same parts of the tree today 😆
The others need to set custom-phys-address, if not dagger will fail to take up the interface because "The address is not unique on the network"
For example changing SSID
RSSI is a vendor-specific relative index (0-255), while dBm is an absolute power measurement. Since we report dBm values from iw, rename the leaf to signal-strength for accuracy.
Should be like this: ┌────────────┬────────────────────┐ │ RSSI (dBm) │ Status │ ├────────────┼────────────────────┤ │ ≥ -50 │ excellent (strong) │ ├────────────┼────────────────────┤ │ -60 to -51 │ good │ ├────────────┼────────────────────┤ │ -70 to -61 │ poor │ ├────────────┼────────────────────┤ │ < -70 │ bad (weak) │ └────────────┴────────────────────┘
mattiaswal
changed the title
troglobit
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: