Upgrade dependencies#48
Open
tylervz wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request upgrades several Node dependencies of the extension.
I removed
vscodefrom package.json and rannpm i -D @types/vscodeandnpm i -D vscode-test @vscode/test-cli @vscode/test-electronbecause thevscodepackage has been replaced by those.And then I updated the VSCode config files to match those of a new extension generated with
npx --package yo --package generator-code -- yo codeas described in the documentation. This involved updating thepackage.jsonscripts to copy thelanguage-configurationfolder tooutafter compilation and updating the paths insrc/configuration.tsbecause therootDirchanged from"."to"src"intsconfig.json.It seems that upgrading the dependencies of this extension has fixed this bug (#47). It launches fine from VS Code when the
..../src/xaml/language-configuration.jsonfile on my computer has a trailing comma in theonEnterRulesarray. But if I remove the opening square bracket of theonEnterRulesarray, then this extension reports problems when I try to launch it.