Open
Conversation
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
Contributor
Author
|
hi @kevinkhill! hope you review this, thank you |
Owner
|
Oh wow, you really overhauled everything. I am interested to see what you
did. I'll try and take a look sometime soon. Thank you! 🙏
…On Sat, Apr 26, 2025, 8:21 AM Lloric Mayuga Garcia ***@***.***> wrote:
*lloricode* left a comment (kevinkhill/php-duration#29)
<#29 (comment)>
hi @kevinkhill <https://github.com/kevinkhill>! hope you review this,
thank you
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACA6XGXKMXAUUKKA4JHZQL23OQA7AVCNFSM6AAAAAB35PCY5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZSGMYTINBQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
been tested on production, and it is great |
Contributor
Author
|
Hi @kevinkhill, it is been used this in production and working as expected, can you review it now? thank you |
lloricode
commented
Jun 8, 2025
Contributor
Author
lloricode
left a comment
lloricode
left a comment
There was a problem hiding this comment.
hi @kevinkhill, hope you can review this, thank you
Owner
|
Hi there, so... Seeing how I'm probably never going to find time to do this... You will probably be better off forking it for your own purposes. |
Contributor
Author
|
understood, let this PR open, so others will see |
Contributor
Author
|
on my end it is working as expected, since this PR we already use it on our production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.