MDIReader: Added "photons" and "general" input flags#20
Open
aciarma wants to merge 27 commits intokey4hep:mainfrom
Open
MDIReader: Added "photons" and "general" input flags#20aciarma wants to merge 27 commits intokey4hep:mainfrom
aciarma wants to merge 27 commits intokey4hep:mainfrom
Conversation
Conflicts: k4Gen/options/mdireader_test.py
synch with main
Contributor
|
Hi Andrea, what is the status of this PR? |
BrieucF
reviewed
Mar 30, 2023
| declareProperty("CrossingAngle",xing,"Half the crossing angle beam in [rad]"); | ||
| declareProperty("LongitudinalCut",cut_z,"the value for cut_z used in GP++ in [um]"); | ||
| declareProperty("InputType",input_type,"string: guineapig, xtrack"); | ||
| declareProperty("InputType",input_type,"string: guineapig, xtrack, photons, general"); |
Contributor
There was a problem hiding this comment.
Could you add here an explanation about what those input types correspond to? It is not immediately obvious to me, especially the two new additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the possibility to read photons coming from BDSIM for SR studies, and a "general" flag to read custom input text files for particles to be tracked in the detector.