Remove support for legacy I/O components#475
Open
tmadlener wants to merge 8 commits intokey4hep:mainfrom
Open
Conversation
Don't use the to be deprecated DataHandle for the PodioDataSvc and instead store directly into format that is understood and usable via Functionals and IOSvc. Use new k4FWCore functionality to assign an id on the fly.
This breaks conversion using the PodioDataSvc since the MetadataSvc does not talk to that frame
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
This is largely just removing things. I have moved the
getEDM4hepEventinto the commonStoreUtilssince we need this in both directions. Otherwise it's essentially just switching to newer utilities from k4FWCore and removing / changing tests that usedk4DataSvc.k4FWCore::(get|put)CellIDEncodingAlgTool)