Conversation
…tracker (VTXDigiDetailed) VTXDigiDetailed is currently a copy of VTXDigi + implementation of the primary_ionization function which creates the charges along the incoming particle path. Note that for now VTXDigiDetailed runs exactly the same method than VTXDigi. The goal will be to implement the full digitization of the hits, considering charge production and drift inside the active material and consider the readout response. This needs a pixel segmentation of the corresponding layers in k4geo (see https://github.com/jessy-daniel/k4geo/tree/Add_pixels_tracker)
…frame with z always orthogonal to sensor
…es an issue in EDM4HEP->LCIO converter (to study)
…eCollection in Digitizer output
…_Detailed_VTXdigitizer
…_Detailed_VTXdigitizer
…ls in the cloud to have the same charge
|
The last commits were for debuging some last minutes bug I noticd when running the reconstruction steps after digitizer. |
|
Hi @jmcarcell @andresailer @BrieucF , could you plmease let me know if this can be merged now or what is missing ? |
|
Hi @jmcarcell, Thank you for all your help. I did the changes in the test files and CMakeList |
|
Looks like the test doesn't pass |
Hi @jmcarcell , yes. As the test works locally with ctest, I think this is due to the way we deal with paths in the makefile and test file, as git creates a job that probably mis-reproduce the paths. I will try to work on it later today |
|
Try to run them in lxplus in a clean environment after sourcing the nightlies |
It is exactly what I do and that works on lxplus. As said, I think this is just due to some paths that I will correct. Because the test is running, it just does not find the output file |
|
Dear @jmcarcell ; I hope this is OK now. Could you please try to launch the workflow ? |
|
Hi @jmcarcell @BrieucF , I did the modification on Overlay. Could you please launch the workflows ? |
|
Looks good to me, if there are no more comments I'll merge later today. |
Hi @jmcarcell. Thank you, everything is OK on my side |
|
@jessy-daniel Just out of curiosity: is there a specific reason why the detailed digitizer isn’t included in the VTXdigi folder? Wouldn’t it be more coherent to keep it together with the other VTX digitizers? |
@andread3vita , VTXDigi is doing exactly the same than DDplanarDigiProcessor in Marlin (which was used up to now), that is to say just using parametrizable hit resolution and smearing the hit position by this resolution. |
|
@jessy-daniel, I agree with you that this is a completely different digitizer. My concern is more about the overall structure of the repository, especially considering future developments. For example, there will also be a detailed digitiser for the drift chamber and, if I am not mistaken (@s6anloes , please correct me if I’m wrong), it is planned to be placed in DCHdigi. |
7 participants
BEGINRELEASENOTES
ENDRELEASENOTES