fix missing cellID encoding error#93
Open
giovannimarchiori wants to merge 1 commit intokey4hep:mainfrom
Open
Conversation
Contributor
Author
|
Tagging @BrieucF @scott-snyder |
jmcarcell
reviewed
Apr 7, 2026
| return StatusCode::FAILURE; | ||
| } | ||
| auto cellIDEncodingName = podio::collMetadataParamName(m_outHits.objKey(), edm4hep::labels::CellIDEncoding); | ||
| k4FWCore::putParameter(cellIDEncodingName, m_descriptor.fieldDescription(), this); |
Member
There was a problem hiding this comment.
Suggested change
| k4FWCore::putParameter(cellIDEncodingName, m_descriptor.fieldDescription(), this); | |
| k4FWCore::putCellIdEncoding(m_outHits.objKey(), m_descriptor.fieldDescription(), this); |
This will be possible after key4hep/k4FWCore#391 is merged. I suggest waiting.
Contributor
Author
There was a problem hiding this comment.
@jmcarcell do you know when that MR will be merged?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to revive the FCC-hh digitisation scripts, I encountered an error when using the MergeLayers algorithm, related to the fact that its output cells, later used by other algorithms, lack a Cell ID encoding. This MR fixes that error
BEGINRELEASENOTES
ENDRELEASENOTES