Add UntilCompleted Unique Job Lock Strategy#158
Closed
jam-packed wants to merge 1 commit intokeypup-io:masterfrom
Closed
Add UntilCompleted Unique Job Lock Strategy#158jam-packed wants to merge 1 commit intokeypup-io:masterfrom
jam-packed wants to merge 1 commit intokeypup-io:masterfrom
Conversation
Member
|
Code looks good 👍 Thanks for submitting this! 🤗 Looks like I just need to fix the appraisals on master. I'll do that next week so you can rebase. |
Contributor
Author
|
@alachaum Is this ready to be rebased yet? 👀 |
Member
|
I've manually merged this PR into master 🎉 |
Member
|
Version |
Contributor
Author
|
@alachaum Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the UntilCompleted lock strategy to the unique job locking mechanism in Cloudtasker. The lock is only released upon successful completion or when a DeadWorkerError is raised.
This PR is a result of this enhancement request