Fix broken types for field groups and access functions#8617
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
changed the title
borisno2
approved these changes
Jun 8, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8570 introduced
Sessiontypes to a number of the Typescript types throughout a typical Keystone configuration, and actually strengthened the types to the degree that a number of existing configurations became unreasonable to fix, like when usinggroups.groupdidn't actually support using a refinedListTypeInfotype, which led to types that you couldn't actually fix without explicitly usinggroup<any, Lists.Post.TypeInfo>, which isn't ideal, or necessary.This pull request fixes this problem that so
groupwill now continue to work in code whereListTypeInfohas been refined fromBaseListTypeInfo(the default), without explicitly requiring type parameters.This pull request also should fix #8616 by returning the exact types of the literal functions provided instead of attempting to automatically infer them. When users (like @Thinkscape) are using type prefixes like
lists: Lists, this shouldn't break their code now.