Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c27a3b8:
|
|
I'm using this functionality on a project right now and would be sad to see it go.
I'm curious what shortcomings people are seeing in this and what DIY systems they're building. If this functionality is removed, I'd hope to see a good replacement suggestion in documentation. |
|
@andy-blum fair point, maybe I can add an example to this pull request, and from there we can discuss how the example fairs compared to the inbuilt functionality. |
|
Looks good @dcousens - just put in a rough first pass example of a magicAuthExample without using the auth package in case that is useful |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
| async resolve (args, { userId, token }, context: Context) { | ||
| if (!context.sessionStrategy) throw new Error('No session implementation available on context') | ||
|
|
||
| const kdf = (base.schema.getType('User') as any).getFields()?.password.extensions?.keystoneSecretField |
There was a problem hiding this comment.
Don't love this, but I'll address somewhere else
|
Typescript errors will be fixed by #9402 |
3 participants
This pull request removes the magicAuthLink and passwordResetLink functionality from
@keystone-6/auth. The rationale is that this functionality is often unused and consequently unmaintained within the project.While passwordResetLink functionality can be helpful, most projects I have seen have implemented their own versions, often finding the provided interface unsatisfactory. The community has shown that
@keystone-6/authdoes not adequately support this functionality, as seen in discussions like this one, leaving developers to write most of the feature themselves.This change will reduce the complexity of the
@keystone-6/authmodule, which is a precursor to initiatives such as #8097.#8097 and other initiatives seek to add support for advanced authentication methods (like MFA) and functionality to Keystone in a new and improved manner.
If you know of any projects that rely on these features and would be adversely affected by their removal, please share your experiences and use cases.