wip - playing with a keystatic-based examples explorer#9285
Draft
kennedybaird wants to merge 1 commit intokeystonejs:mainfrom
Draft
wip - playing with a keystatic-based examples explorer#9285kennedybaird wants to merge 1 commit intokeystonejs:mainfrom
kennedybaird wants to merge 1 commit intokeystonejs:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit efe6b52:
|
Contributor
Author
|
@simonswiss - I'd love to keep playing with this idea, but will save putting time in until there's some feedback. Hope you can take a glance this week 🙏 |
Contributor
Author
|
I'd still be interested in following through with this - if it's a no go then I would go back to transitioning all the examples to the new codesandbox approach so that they're at least working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an idea for managing part of the examples with keystatic (just a rough quick example).
It would use/manage the README.md file for each example and adds the ability to define a preview file, and select related docs.
It has some important notes:
.yamlfile in each dir - which could be confusing for end users (side note: maybe those files should have a commented#keystatic fileat the start of them?)docs/examplesas keystatic can't access the dir above (or keystatic needs to move to the project root, but I don't think that's appropriate)What I like about this: