Improve client side filters and apply actionMode filters properly#9793
Draft
Improve client side filters and apply actionMode filters properly#9793
Conversation
emmatown
changed the title
emmatown
force-pushed
the
fix-client-side-filters
branch
2 times, most recently
from
e45114c to
a6483d2
Compare
emmatown
force-pushed
the
fix-client-side-filters
branch
2 times, most recently
from
6d3e8c3 to
9e77b11
Compare
emmatown
force-pushed
the
fix-client-side-filters
branch
from
9e77b11 to
3e4f684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the client-side filters added in #9620 (currently unreleased) and properly applies them for actionMode.
editandenabledinfieldModeandactionModerespectively are no longer in the conditional filters, instead the mode isedit/enabledif the other modes don't match.