-
-
Notifications
You must be signed in to change notification settings - Fork 1
📝 Add permissions needed for private repos #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
b350242
16901a8
2e182a2
06ca605
9dd9e89
efb3ed4
e71844a
0814a27
4835338
dbde27c
40c7c44
0d558bc
73ea487
a503680
2f63b8f
edec00b
358bb9f
727abda
dae3e6c
ec2822e
3c3354f
82c5656
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,9 @@ on: | |
| jobs: | ||
| latest-changes: | ||
| runs-on: ubuntu-latest | ||
| # Needed for private repos | ||
| permissions: | ||
| pull-requests: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: khulnasoft/latest-changes@0.3.2 | ||
|
|
@@ -164,6 +167,9 @@ on: | |
| jobs: | ||
| latest-changes: | ||
| runs-on: ubuntu-latest | ||
| # Needed for private repos | ||
| permissions: | ||
| pull-requests: read | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: khulnasoft/latest-changes@0.3.2 | ||
|
|
@@ -276,6 +282,9 @@ on: | |
| jobs: | ||
| latest-changes: | ||
| runs-on: ubuntu-latest | ||
| # Needed for private repos | ||
| permissions: | ||
| pull-requests: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
|
|
@@ -304,6 +313,10 @@ So, the commits will still be shown as made by `github-actions`. | |
|
|
||
| ### Latest Changes - Latest Changes 🤷 | ||
|
|
||
| * ⬆ Bump actions/checkout from 5 to 6. PR [#6](https://github.com/khulnasoft-bot/latest-changes/pull/6) by [@dependabot[bot]](https://github.com/apps/dependabot). | ||
| * ⬆ Bump actions/cache from 4 to 5. PR [#7](https://github.com/khulnasoft-bot/latest-changes/pull/7) by [@dependabot[bot]](https://github.com/apps/dependabot). | ||
| * ⬆ Bump actions/upload-artifact from 5 to 6. PR [#8](https://github.com/khulnasoft-bot/latest-changes/pull/8) by [@dependabot[bot]](https://github.com/apps/dependabot). | ||
| * 📝 Add permissions needed for private repos. PR [#9](https://github.com/khulnasoft-bot/latest-changes/pull/9) by [@khulnasoft-bot](https://github.com/khulnasoft-bot). | ||
| * 📝 Tweak docs with new label infra. PR [#4](https://github.com/khulnasoft-bot/latest-changes/pull/4) by [@khulnasoft-bot](https://github.com/khulnasoft-bot). | ||
| * ⬆ Bump actions/checkout from 4 to 5. PR [#3](https://github.com/khulnasoft-bot/latest-changes/pull/3) by [@dependabot[bot]](https://github.com/apps/dependabot). | ||
| * ⬆ Bump actions/upload-artifact from 4 to 5. PR [#2](https://github.com/khulnasoft-bot/latest-changes/pull/2) by [@dependabot[bot]](https://github.com/apps/dependabot). | ||
|
|
@@ -313,6 +326,10 @@ So, the commits will still be shown as made by `github-actions`. | |
| * ✨ Prevent CI workflows from running on a latest changes commit, add […. PR [#15](https://github.com/khulnasoft/latest-changes/pull/15) by [@khulnasoft-bot](https://github.com/khulnasoft-bot). | ||
| * ⬆ Bump khulnasoft/issue-manager from 0.5.0 to 0.5.1. PR [#11](https://github.com/khulnasoft/latest-changes/pull/11) by [@dependabot[bot]](https://github.com/apps/dependabot). | ||
|
|
||
| #### Features | ||
|
|
||
| * 🔧 Update GitHub Actions bot user configuration. PR [#5](https://github.com/khulnasoft-bot/latest-changes/pull/5) by [@khulnasoft-bot](https://github.com/khulnasoft-bot). | ||
|
|
||
|
Comment on lines
+329
to
+332
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update README bot identity text to match this new release-note entry. This section now documents the bot-user-config change, but the “How does it work?” section still says commits are authored as 🤖 Prompt for AI Agents |
||
| #### Refactors | ||
|
|
||
| * Revert "♻️ Refector Update main.py". PR [#13](https://github.com/khulnasoft/latest-changes/pull/13) by [@NxPKG](https://github.com/NxPKG). | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -233,9 +233,9 @@ def main() -> None: | |
| sys.exit(1) | ||
|
|
||
| logging.info("Setting up GitHub Actions git user") | ||
| subprocess.run(["git", "config", "user.name", "github-actions"], check=True) | ||
| subprocess.run([git_bin, "config", "user.name", "github-actions[bot]"], check=True) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. security (python.lang.security.audit.dangerous-subprocess-use-audit): Detected subprocess function 'run' without a static string. If this data can be controlled by a malicious actor, it may be an instance of command injection. Audit the use of this call to ensure it is not controllable by an external resource. You may consider using 'shlex.escape()'. Source: opengrep |
||
| subprocess.run( | ||
| ["git", "config", "user.email", "github-actions@github.com"], check=True | ||
| [git_bin, "config", "user.email", "github-actions[bot]@users.noreply.github.com"], check=True | ||
| ) | ||
|
Comment on lines
237
to
239
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. security (python.lang.security.audit.dangerous-subprocess-use-audit): Detected subprocess function 'run' without a static string. If this data can be controlled by a malicious actor, it may be an instance of command injection. Audit the use of this call to ensure it is not controllable by an external resource. You may consider using 'shlex.escape()'. Source: opengrep |
||
| number_of_trials = 10 | ||
| logging.info(f"Number of trials (for race conditions): {number_of_trials}") | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The
actions/checkout@v6tag may not exist and could cause the workflow to fail.actions/checkoutis currently published up tov4(withv4.x.xtags). Using@v6will fail withResource not founduntil that version exists. Please pin to the latest available major (e.g.,@v4) or a specificv4.x.xtag instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.