Fix incompatible charset & collation and change it to utf8mb4#8
Open
Maxooo wants to merge 3 commits intokilhage:masterfrom
Open
Fix incompatible charset & collation and change it to utf8mb4#8Maxooo wants to merge 3 commits intokilhage:masterfrom
Maxooo wants to merge 3 commits intokilhage:masterfrom
Conversation
|
just ran into this issue myself, so would welcome this to be changed. |
|
Just ran into this issue too. If you could merge it we would be very grateful ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to resolve the following problematics.
Doctrine Charset
If the Doctrine charset defined in the project configuration is not equal to
utf8it become impossible for Doctrine to create the schema as it try to create the table with incompatible charset and collation.For example if your project is configured like this :
(...) running the
bin/console doctrine:schema:createcommand will result in the following error :Setting the charset explicitly and accordingly with the collation in the table definition will fixi this issue.
Alphabet limitations
As we are working on this part, I recommend to change the collation
swedishto the more standardized oneunicodeusing theutf8mb4charset to support Asian and more foreign alphabets.