Skip to content

migrate to jakarta namespace#104

Draft
Copilot wants to merge 3 commits intojava2xfrom
copilot/migrate-killbill-commons-integration
Draft

migrate to jakarta namespace#104
Copilot wants to merge 3 commits intojava2xfrom
copilot/migrate-killbill-commons-integration

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 14, 2026

  • Audit current Java EE and Jooby usage in the repository and review the baseline Maven commands
  • Replace upstream Jooby dependencies with the Kill Bill fork and centralize the commons and Jakarta version overrides in the root POM
  • Migrate repository-local servlet-facing imports and integration code from javax.servlet to jakarta.servlet where required
  • Run Maven package, test, and verify with JDK 21
  • Record current validation blocker: mvn test and mvn verify fail in the sandbox because embedded MySQL cannot start without libaio.so.1
  • Create or update the PR titled migrate to jakarta namespace

Copy link
Copy Markdown
Contributor

@xsalefter xsalefter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot

  1. To fix the current problem, changes spotbugs-exclude.xml to code below:
<!--
  ~ Copyright 2020-2021 Equinix, Inc
  ~ Copyright 2014-2021 The Billing Project, LLC
  ~
  ~ The Billing Project licenses this file to you under the Apache License, version 2.0
  ~ (the "License"); you may not use this file except in compliance with the
  ~ License.  You may obtain a copy of the License at:
  ~
  ~    http://www.apache.org/licenses/LICENSE-2.0
  ~
  ~ Unless required by applicable law or agreed to in writing, software
  ~ distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
  ~ WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
  ~ License for the specific language governing permissions and limitations
  ~ under the License.
  -->

<FindBugsFilter>
    <Bug pattern="EI_EXPOSE_REP"/>
    <Bug pattern="EI_EXPOSE_REP2"/>
    <!-- Constructor validates and normalizes input URLs, and the checked exception is part of the public API. -->
    <Match>
        <Bug pattern="CT_CONSTRUCTOR_THROW"/>
        <Class name="org.killbill.billing.plugin.api.payment.PluginHostedPaymentPageFormDescriptor"/>
    </Match>
    <!-- Constructor performs DB metadata and schema resolution eagerly, and SQL failures are part of the public API. -->
    <Match>
        <Bug pattern="CT_CONSTRUCTOR_THROW"/>
        <Class name="org.killbill.billing.plugin.dao.PluginDao"/>
    </Match>
    <!-- Constructor builds SSL/HTTP client state eagerly, and security setup failures are part of the public API. -->
    <Match>
        <Bug pattern="CT_CONSTRUCTOR_THROW"/>
        <Class name="org.killbill.billing.plugin.util.http.HttpClient"/>
    </Match>
</FindBugsFilter>
  1. Additionally, remove this maven deps as it is not used anymore:
  <groupId>com.github.spotbugs</groupId>
  <artifactId>spotbugs-annotations</artifactId>

Copy link
Copy Markdown
Author

Copilot AI commented Apr 15, 2026

@copilot

  1. To fix the current problem, changes spotbugs-exclude.xml to code below:...

Addressed in 46c0d56. I updated spotbugs-exclude.xml with the requested constructor filters, removed the direct spotbugs-annotations dependency, removed the remaining direct SpotBugs suppression usage, and fixed SslUtils so JAVA_HOME=/usr/lib/jvm/temurin-21-jdk-amd64 mvn -B -ntp -DskipTests verify now passes.

Copilot AI requested a review from xsalefter April 15, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants