adds a package.json for the necessary required modules#8
Open
iamdtang wants to merge 1 commit intokimjoar:masterfrom
iamdtang:master
Open
adds a package.json for the necessary required modules#8iamdtang wants to merge 1 commit intokimjoar:masterfrom iamdtang:master
iamdtang wants to merge 1 commit intokimjoar:masterfrom
iamdtang:master
Conversation
|
👍 +1 |
|
👍 |
|
Up! 👍 |
Owner
|
As noted in the readme I don't have time to maintain this repo. If someone wants to do it, get in touch. |
|
"jasmine-core": "^2.4.1" add to package.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you run karma start, it wont work because the necessary dependencies aren't included. I put them in the package.json so someone can just run 'npm install' and then karma start and everything should just work without them having to figure out what are the missing modules.