Improvements for Loopback Integrations#19
Open
zeerobug wants to merge 11 commits intokimkha:masterfrom
Open
Conversation
Modified Readme to replace admin-on-rest (discontinued) by react-admin Modified Readme to describe the function to implement in loopback to make it work
Owner
|
Thank you for your hard work and PR. I have a question: why don't you just use default I think it's good for this plugin if we make this plugin simple: We have a default authentication which greatly integrate to default Loopback, and user can change to custom authentication url for themselves if they want. |
Author
|
Hi,
You are right, we have to keep it simple, I just copied and paste my function. I use customer because I needed to extend the default model.
Please modify the README as you wish.
Cheers,
Thomas
… On 10 Jul 2018, at 17:23, Nguyễn Kim Kha ***@***.***> wrote:
Thank you for your hard work and PR.
I have a question: why don't you just use default User model for authentication? Why must you create new model called Customer on your Loopback?
I think it's good for this plugin if we make this plugin simple: We have a default authentication which greatly integrate to default Loopback, and user can change to custom authentication url for themselves if they want.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASTa9fEMi5fvY1ksShWiL7MkO8wB9aNGks5uFMbjgaJpZM4VJC4r>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kimkha,
This is a fork for:
AUTH_GET_PERMISSIONScaseThere is a pending TODO to integrate Loopback side functions as hooks, which I can't do right now.
Thank you for your work !