Fix "Could not find method kotlin()" on AGP 9 when built-in Kotlin is off#90
Merged
Conversation
… off
The kotlin {} DSL is only registered by the Kotlin Gradle Plugin. On AGP 9 with
android.builtInKotlin=false (the Flutter template default), KGP is skipped, so the
unconditional kotlin {} block failed with "Could not find method kotlin()".
- Configure kotlin {} only via plugins.withId("org.jetbrains.kotlin.android")
- Apply kotlin-android whenever built-in Kotlin is off (agpMajor < 9 || !builtInKotlin)
Fixes #86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Could not find method kotlin()build failure on AGP 9 whenandroid.builtInKotlin=false(the Flutter template default). On AGP 9 the Kotlin Gradle Plugin is skipped, so the unconditionalkotlin {}block had no provider.kotlin {}DSL only when KGP is applied (plugins.withId("org.jetbrains.kotlin.android")), and applykotlin-androidwhenever built-in Kotlin is off (agpMajor < 9 || !builtInKotlin).Test plan
builtInKotlin=false); the fix builds cleanly.builtInKotlin=true(AGP 9) and AGP 8.11.1 both still build.Fixes #86