Add BDEI and BDSS linear phylodynamic models#6
Merged
Conversation
Add yaml/bdss.yml and register the model with minimal wiring in init.c, simulate.R, and yaml.R. Generated C++ and R bindings included; no bulk regeneration of existing models.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
==========================================
- Coverage 98.91% 98.80% -0.11%
==========================================
Files 71 75 +4
Lines 3764 3926 +162
==========================================
+ Hits 3723 3879 +156
- Misses 41 47 +6 🚀 New features to boost your workflow:
|
Register yaml/bdei.yml with minimal wiring alongside the existing BDSS addition: only new model files plus init.c, simulate.R, and yaml.R patches.
Exercise initial grafting when IE0 > 0 or IS0 > 0 so patch coverage reaches 100% for the new model code.
Use pop with deme fractions for initial counts, rename transmission rates to lambda_*, set rate defaults to PhyloDeep training-prior midpoints, and cite Voznica, Stadler, and King in the YAML details blocks.
Owner
|
@Horopter : I'd like to harmonize the parameter names in the codes you've written with those used in the rest of the package. I've adjusted the names in the BDEI case: perhaps you can make the corresponding adjustments in the BDSS case? |
Owner
|
@Horopter : see my changes to your pull request. Can you make the corresponding changes for the BDSS model? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yaml/bdei.ymlandyaml/bdss.ymlfor two-deme linear birth-death processes used in PhyloDeep (Voznica et al.)..cc/.Rfiles plus small patches toinit.c,simulate.R, andyaml.R.add_model.R.pop,fn/fsorfe/fi) matching themers.ymlpattern.lambda_*(lambda_iein BDEI;lambda_nn,lambda_ns,lambda_sn,lambda_ssin BDSS).treesimulatorconventions).detailsblock.King et al. / Voznica alignment
exposedandinfectious(King Fig. 1A genealogy restriction). Rates:mu(E→I),lambda_ie(I→E birth),psi(I removal), Stadler samplingpon infectious removal — matchestreesimulatorBirthDeathExposedInfectiousModel. Default rates implyTest plan
Rscript tests/bdei.RRscript tests/bdss.Rpop+ deme fractions → integer initial counts)