Improve workflow DX, manifests, and generated APIs#20
Merged
kingwill101 merged 23 commits intomasterfrom Mar 19, 2026
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 265 files, which is 115 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (265)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afc51c1f1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+1272
to
+1276
| buffer.writeln(' static final PayloadCodec<$typeCode> $symbol ='); | ||
| buffer.writeln(' PayloadCodec<$typeCode>('); | ||
| buffer.writeln(' encode: (value) => value.toJson(),'); | ||
| buffer.writeln( | ||
| ' decode: (payload) => $typeCode.fromJson(' |
There was a problem hiding this comment.
_payloadCodecTypeCode accepts codec-backed DTOs even when the annotated type is nullable, so this emitter will generate PayloadCodec<Foo?> plus value.toJson() and Foo?.fromJson(...). That is invalid Dart, which means any annotated task/workflow parameter, result, or checkpoint that uses an optional DTO will fail codegen/builds instead of producing a usable helper.
Useful? React with 👍 / 👎.
Comment on lines
524
to
528
| return StemWorkflowApp.create( | ||
| module: module, | ||
| workflows: workflows, | ||
| flows: flows, | ||
| scripts: scripts, |
There was a problem hiding this comment.
StemWorkflowApp.fromClient
This factory now accepts a tasks iterable, but the StemWorkflowApp.create(...) call never passes it through. In the fromClient path, any workflow that depends on handlers supplied via tasks: will start without those handlers in the shared registry, so step-enqueued work can be dead-lettered as an unregistered task even though the caller provided the handler list.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch overhauls Stem's workflow/task DX and related docs.
It does four main things:
tasks:and generated bundles the default wiring path instead of manual registriesHighlights
Workflow runtime and DX
StemModule, typedWorkflowRef/WorkflowStartCall, typed task definition helpers, and generated bundle-first builder outputtasks:-first wiring acrossStem,Worker,Canvas, andStemWorkflowAppExamples and docs
.siteand refresh READMEs/snippets to match the current APIsAdapters and stores
Compatibility and safety
SimpleTaskRegistryas a deprecated compatibility aliasTesting
Ran targeted validation across the changed areas, including:
dart testforpackages/stem,packages/stem_builder,packages/stem_memory,packages/stem_sqlite,packages/stem_redis, andpackages/stem_postgresworkflow/store/bootstrap suitesdart analyzeon the changed package setsnpm --prefix .site run buildNotes
master.