Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was
linked to
issues
Aug 31, 2024
DannySS123
requested changes
Sep 3, 2024
DannySS123
left a comment
DannySS123
left a comment
There was a problem hiding this comment.
Nice job!
Some things to improve:
- redirect when the event is created
- remove the hardcoded parts (there are some user selectors in the konzisite)
- if the ownerId doesn't exist I get 500 error codes from the backend. This means that some cases aren't handled yet. Normally we should never get 500-s, so please fix it.
- the description looks strange in the middle of the textbox, and I can't write enters
I was able to create an event, so it works nicely (although I had to create the user with the ownerId), so great job, keep up the good work! 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working form for creating events.