Conversation
OmTheTurtle
reviewed
Jul 2, 2021
OmTheTurtle
reviewed
Jul 2, 2021
OmTheTurtle
reviewed
Jul 2, 2021
When this is enabled, the website can be easily tested with multiple accounts
4507127 to
b931f77
Compare
b931f77 to
9740606
Compare
It lost the behaviour on a destruction. Refactored code to don't use destruction.
subfeatures: - Hide the user's name if needed - Show approve button on unapproved users for moderators
This reverts commit 9d26d2b.
1e6f738 to
8a33968
Compare
Contributor
Author
Contributor
Author
|
We could send emails to the user when they are approved or kicked out. |
tomitheninja
commented
Aug 27, 2021
| } | ||
|
|
||
| export async function down(knex: Knex): Promise<void> { | ||
| // TODO: drop enum `group_roles` |
Contributor
Author
There was a problem hiding this comment.
Drop the enum on migrate:down, or else the second migrate:up will fail, because the enum already exists
Contributor
Author
There was a problem hiding this comment.
I could use some help with this one 😅
Member
There was a problem hiding this comment.
I tried searching knex docs but didn't really find anything, worst case you can use .raw with DROP TYPE group_roles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Closes #330