Fix race condition when two processes build the same core image - #5
Open
kisp wants to merge 2 commits into
Conversation
…build the same core image at the same time #3
Two concurrent sbcl-wrap processes building the same core image would both pipe a save-lisp-and-die call writing to the same path, corrupting the file. Fix: each process writes to <imagePath>.tmp.<pid>, then calls POSIX rename(2) which atomically replaces the destination. If two processes race to rename, one silently overwrites the other with an equivalent image and both callers proceed normally. On build failure the tmp file is removed (best-effort). Closes #3 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
What was wrong
ensureImagechecksdoesFileExist, getsFalse, and callsmakeImage. If two processes do this simultaneously they both pipe a Lisp script ending in(sb-ext:save-lisp-and-die "<imagePath>")to separate SBCL processes. Both write to the same path concurrently, corrupting the core file.Fix
Each call to
makeImagenow writes to a private temp file:On success, POSIX
rename(2)moves it atomically toimagePath.renameon Linux replaces the destination if it already exists, so if two processes race to rename, one silently overwrites the other with an equivalent image and both callers proceed normally.On build failure the temp file is removed (best-effort via
catchIOError).Changes
sbclScriptgains atmpPathparameter;save-lisp-and-dietargetstmpPathwhileensure-directories-existstill usesimagePath(same directory, ensures the cache dir exists)makeImagecallsgetProcessIDto formtmpPath, passes it tosbclScript, thenrenames on success or cleans up on failuregetProcessID,System.Posix.Files.rename,catchIOErrorTest plan
nix buildpasses (binary produced)HOME="$(mktemp -d)" nix run .#testto run the integration suite