Fix string data in JST#3
Open
marocchino wants to merge 1 commit intokissy2go:masterfrom
Open
Conversation
marocchino
commented
Aug 23, 2018
| Time.strptime(@value, format) rescue return super | ||
| super | ||
| end | ||
| time.to_i rescue super |
Author
There was a problem hiding this comment.
maybe we don't need to_i here.
just return Time type will be break nothing.
The timestamp should be explicitly changed to Time in Rails, which is quite painful.
[1] pry(main)> pr = Product.first
[2] pry(main)> pr.update(updated_at: 1234567890)
(0.2ms) BEGIN
Product Update (1.0ms) UPDATE "products" SET "updated_at" = $1 WHERE "products"."id" = $2 [["updated_at", nil], ["id", 4729]]
(0.2ms) ROLLBACK
ActiveRecord::NotNullViolation: PG::NotNullViolation: ERROR: null value in column "updated_at" violates not-null constraint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GMO API returns date value as JST string. I use 'tokyo' time zone in my rails.
But the changed time is utc So this difference causes a time lag in my app.
If incompatible with the existing operation is problem, you may want to let the user select the other in the configuration options something like this: