-
Notifications
You must be signed in to change notification settings - Fork 2
Use githubs gitignore files. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
VolkerHartmann
merged 6 commits into
kit-data-manager:master
from
Pfeil:better-gitignore
Jul 15, 2022
Merged
Use githubs gitignore files. #5
VolkerHartmann
merged 6 commits into
kit-data-manager:master
from
Pfeil:better-gitignore
Jul 15, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5671d2e to
905c9bd
Compare
Member
Author
|
Sorry for the force push, I thought I did not have a pull request already. But well. I almost forgot about that branch.
What do you think? |
Member
Author
|
If this is fine, I think you'll have to merge, I think I can not ... probably that is why I forked the template repo back then :) |
Member
Author
|
Merging the master has deleted the travis.yaml, still it seems to be triggered? The rest of the CI is probably fixed by #6 by then. |
VolkerHartmann
requested changes
Nov 30, 2021
VolkerHartmann
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd prefer to use this kind of gitignore file. It uses some of the well-maintained lists from https://github.com/github/gitignore. This makes basically two changes:
/src. If a legit exception has to be added, it can be done like this:!/setup/build/env.shbut to be honest I do not expect this to happen.I left in some things I was not able to tell where it is coming from, namely
/.settings/and/config/, so no lines or files were left out in the end.