Skip to content

Conversation

@Pfeil
Copy link
Member

@Pfeil Pfeil commented Nov 23, 2021

  • should we remove the travis.yml?
  • what has to be done for $code_coverage_dashboard?

@ThomasJejkal
Copy link
Contributor

Point 1: yes
Point 2: Doesn't the metastore2 configuration helps on this?

@Pfeil
Copy link
Member Author

Pfeil commented Nov 24, 2021

Point 1: Done
Point2: Well yes and no. Metastore (and other projects, too) also have a gradle dependency to a coveralls library, and I am not sure yet what the official way is etc.

@ThomasJejkal
Copy link
Contributor

Well, I think you need the dependency anyways. Which alternative do you see?

@Pfeil
Copy link
Member Author

Pfeil commented Nov 24, 2021

I think the dependency is not used by the CI, is it? Maybe I just do not understand how it works. I also just noticed that the metastore config uses codecov and I am talking about the coveralls dependency. Do we have a decision on what to use?

@Pfeil
Copy link
Member Author

Pfeil commented Nov 24, 2021

I added the codecov CI workflow. Can be merged now. I will remove the coveralls dependency in the gradle file in #6 .

Copy link
Contributor

@VolkerHartmann VolkerHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment...

Copy link
Contributor

@VolkerHartmann VolkerHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@VolkerHartmann VolkerHartmann merged commit 5fb7387 into kit-data-manager:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants