-
Notifications
You must be signed in to change notification settings - Fork 2
Add github ci. #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pfeil
commented
Nov 23, 2021
- should we remove the travis.yml?
- what has to be done for $code_coverage_dashboard?
|
Point 1: yes |
|
Point 1: Done |
|
Well, I think you need the dependency anyways. Which alternative do you see? |
|
I think the dependency is not used by the CI, is it? Maybe I just do not understand how it works. I also just noticed that the metastore config uses codecov and I am talking about the coveralls dependency. Do we have a decision on what to use? |
|
I added the codecov CI workflow. Can be merged now. I will remove the coveralls dependency in the gradle file in #6 . |
VolkerHartmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment...
VolkerHartmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!