This repository was archived by the owner on Nov 27, 2025. It is now read-only.
Conversation
added 9 commits
May 7, 2025 14:56
Owner
Author
|
Hydrogen is repeating the songs like a lot, my suggestion is to increase the mix index until the music can't be found on the queue. |
There was a problem hiding this comment.
Pull Request Overview
This PR implements an autoplay feature that automatically plays the next track from a YouTube mix when the playback queue is exhausted. Key changes include the addition of a new LoopMode variant "Autoplay" in both the player and command modules, new functions in PlayerManager for autoplay handling and YouTube ID resolution, and updates to i18n files and configurations to support the new feature.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hydrolink/src/cluster.rs | Added a getter for user_id. |
| hydrogen/src/music/player.rs | Updated LoopMode enum and track structure to include autoplay and YouTube identifiers. |
| hydrogen/src/music/mod.rs | Added new autoplay logic and helper functions to fetch YouTube tracks. |
| hydrogen/src/main.rs | Adjusted PlayerManager initialization to pass user id. |
| Various (i18n, commands, TODO, README, CHANGELOG) | Updated localization, command options, documentation, and changelog to integrate autoplay mode. |
Comments suppressed due to low confidence (1)
hydrogen/src/music/player.rs:928
- Consider adding parentheses to clarify operator precedence. If the intention is to compute ((player.current_track + 1) % player.queue.len()), the expression should be updated accordingly to ensure correct wrap-around behavior.
LoopMode::All => (player.current_track + 1 % player.queue.len(), false, true),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.