Skip to content

feat: pie chart v2#809

Merged
mcstover merged 3 commits intomainfrom
feat-pie-chart-v2
Apr 17, 2026
Merged

feat: pie chart v2#809
mcstover merged 3 commits intomainfrom
feat-pie-chart-v2

Conversation

@mcstover
Copy link
Copy Markdown
Collaborator

@mcstover mcstover commented Apr 16, 2026

New Pie Chart Component, checkout the stories once they are published in the storybook preview!

https://608b4cf87f686c00213841b1-pnaxkfsgwh.chromatic.com/?path=/docs/charts-kvpiechartv2--docs

image

Other items of note:

  • This was brainstormed, specced with the help of superpowers and claude with the premise that we were porting a specific react component exported from figma make to a Kiva Vue component.
  • Some of the process notes were compiled into a new make-to-vue.md skill file, there's a lot more we'll want to expand on within this file and likely sub files around this topic but it's a start!
  • Started the process of instantiating a SKILLS.md with an index of the new skill and existing prompts and guidelines files.

@mcstover mcstover requested review from a team, eddieferrer and emuvente April 16, 2026 23:49
Comment thread @kiva/kv-components/src/vue/KvPieChartV2.vue Outdated
Comment thread @kiva/kv-components/src/vue/KvPieChartV2.vue Outdated
Comment thread @kiva/kv-components/src/vue/KvPieChartV2.vue Outdated
Copy link
Copy Markdown
Collaborator

@dyersituations dyersituations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool! Some of the stories have scrollbars in mobile, like loading state. So I'm not sure if that's story config issues or if there are some variations that don't respect the browser width. Some stories do get smaller to fit.

Copy link
Copy Markdown
Collaborator

@eddieferrer eddieferrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, look forward to trying out the new skill!

@mcstover
Copy link
Copy Markdown
Collaborator Author

@dyersituations The default story should now exhibit the responsive nature of the component, testable via the storybook viewport selector.

@mcstover
Copy link
Copy Markdown
Collaborator Author

mcstover commented Apr 17, 2026

@eddieferrer I think skill will be useful but it's likely going to work much better when prompted with a clear goal to port the component AND used in concert with superpowers brainstorming and planning. Additionally, it's useful to add to this prompt that you want to improve the process by adding to this skill! I expect we'll find many other things to instruct against and this may become a folder of topic files to handle specific things such as animation or react -> vue specifics...

@mcstover mcstover changed the title Feat pie chart v2 feat: pie chart v2 Apr 17, 2026
@mcstover mcstover merged commit 66bdbe7 into main Apr 17, 2026
5 checks passed
@mcstover mcstover deleted the feat-pie-chart-v2 branch April 17, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants