Skip to content

feat: ensuring achievement cards are displayed#6855

Open
tiarascoleman wants to merge 4 commits intomainfrom
MP-2692
Open

feat: ensuring achievement cards are displayed#6855
tiarascoleman wants to merge 4 commits intomainfrom
MP-2692

Conversation

@tiarascoleman
Copy link
Copy Markdown
Contributor

@tiarascoleman tiarascoleman requested a review from a team April 22, 2026 11:46
@tiarascoleman tiarascoleman self-assigned this Apr 22, 2026
@tiarascoleman tiarascoleman added the b2c Sends B2C team a message in Slack on PR creation label Apr 22, 2026
Copy link
Copy Markdown
Collaborator

@dyersituations dyersituations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately these changes introduce new issues:

  • Duplicate cards on next steps page
  • New lending focused next step cards missing entirely if experiment enabled

Current in this branch:

Image

@tiarascoleman
Copy link
Copy Markdown
Contributor Author

@dyersituations Ah!! Are we wanting only 1 card to display then? Regarding the duplication, is the indexed card supposed to be an achieved badge or non achieved? I was only making the change for non-completed journey users but realizing this change affects all

@dyersituations
Copy link
Copy Markdown
Collaborator

@dyersituations Ah!! Are we wanting only 1 card to display then? Regarding the duplication, is the indexed card supposed to be an achieved badge or non achieved? I was only making the change for non-completed journey users but realizing this change affects all

@tiarascoleman as described/shown in the ticket, the issue currently is that when the lending focused next steps are enabled with the new experiment, it is just replacing the achievement cards in the carousel, without ensuring those cards still appear in the second carousel/section with the rest of the achievement cards. The screenshot in the ticket is meant to show that there should be a 5th achievement card (4th in the second section), but the "almost funded" card is kicking it out, and the second section isn't showing it. If the region next step card is also shown (user hasn't lent to all regions yet with experiment enabled), then 2 achievement cards would be lost.

@tiarascoleman
Copy link
Copy Markdown
Contributor Author

tiarascoleman commented Apr 23, 2026

Storybook story can be removed but wanted to add to provide additional testing

Current look locally:
(Casey's profile- user with in-progress achievement journey)
Screenshot 2026-04-22 at 8 44 47 PM

(Tiara's profile- user with no in-progress achievement journey)
Screenshot 2026-04-22 at 8 46 37 PM

Storybook testing (experiment enabled context):
Screenshot 2026-04-22 at 8 49 04 PM

If implementation is still incorrect, will reach out to brief pair programming to confirm understanding of ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b2c Sends B2C team a message in Slack on PR creation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants