Skip to content

feat: change bundle size based on balance#6858

Merged
dyersituations merged 1 commit intomainfrom
MP-2713-enable-bundled-live-loans-based-on-balance
Apr 23, 2026
Merged

feat: change bundle size based on balance#6858
dyersituations merged 1 commit intomainfrom
MP-2713-enable-bundled-live-loans-based-on-balance

Conversation

@dyersituations
Copy link
Copy Markdown
Collaborator

@dyersituations dyersituations commented Apr 22, 2026

https://kiva.atlassian.net/browse/MP-2713

An optional balance parameter that allows live loan bundles to be up to 6, existing live loan usage untouched functionally (and cache-wise).

@dyersituations dyersituations requested review from a team April 22, 2026 21:34
@dyersituations dyersituations added the b2c Sends B2C team a message in Slack on PR creation label Apr 22, 2026
Comment thread server/util/live-loan/bundle-size.js
Copy link
Copy Markdown
Collaborator

@christian14b christian14b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Copy Markdown
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any concern with us not getting back the total of count during the primary loaf fetch?

@dyersituations
Copy link
Copy Markdown
Collaborator Author

dyersituations commented Apr 23, 2026

Is there any concern with us not getting back the total of count during the primary loaf fetch?

@mcstover Where specifically? There should be a fallback count everywhere.

When loading the loans? Like the loans returned are less than count?

@mcstover
Copy link
Copy Markdown
Collaborator

Is there any concern with us not getting back the total of count during the primary loaf fetch?

@mcstover Where specifically? There should be a fallback count everywhere.

When loading the loans? Like the loans returned are less than count?

Yea I was thinking if the query didn't result in the full count. Prob not an issue with the recommended loans query but I didn't know for sure if it always fulfilled the requested count.

@dyersituations
Copy link
Copy Markdown
Collaborator Author

Is there any concern with us not getting back the total of count during the primary loaf fetch?

@mcstover Where specifically? There should be a fallback count everywhere.
When loading the loans? Like the loans returned are less than count?

Yea I was thinking if the query didn't result in the full count. Prob not an issue with the recommended loans query but I didn't know for sure if it always fulfilled the requested count.

Good question. From a technical standpoint, all's good. We only add the loan IDs returned:

const loanIds = loanData

And we catch if no loan IDs returned and redirect:

if (!loanIds) {

From a product standpoint, maybe this isn't super, but we have a good fallback in place.

@dyersituations dyersituations merged commit 5b605ca into main Apr 23, 2026
7 checks passed
@dyersituations dyersituations deleted the MP-2713-enable-bundled-live-loans-based-on-balance branch April 23, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b2c Sends B2C team a message in Slack on PR creation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants