feat: removing lending routes as ported to cps combo page#6859
feat: removing lending routes as ported to cps combo page#6859roger-in-kiva wants to merge 1 commit intomainfrom
Conversation
roger-in-kiva
commented
Apr 22, 2026
roger-in-kiva
commented
- removing lending routes as ported to cps combo page
- https://kiva.atlassian.net/browse/MP-2683
|
@roger-in-kiva we don't want to do this yet. We can test the pages on dev on CPS via flux, leaving these in place. |
Oh right, let's keep this open so. |
| }, | ||
| { | ||
| path: '/lend-by-category', | ||
| component: () => import('#src/pages/LoanFinding/LoanFinding'), |
There was a problem hiding this comment.
I think both of these /lend-by-cat routes should become redirects. This one is easy, not sure exactly how the category specific endpoint below will translate to the new page.
| { | ||
| name: 'lend-filter', | ||
| path: '/lend/filter', | ||
| component: () => import('#src/pages/Lend/LoanSearchPage'), |
There was a problem hiding this comment.
If it's possible to set this as a redirect and trigger a full page refresh, that would probably be good to set here. That way we'd be back out at the ingress and flux configs would handle pushing this to cps instead.
There was a problem hiding this comment.
As we are currently having same route on cps, not sure what you mean.
From /lend/filter to /lend/filter?
My guess is adding these routes to cps flux and removing from ui flux, like this:
https://github.com/kiva/flux/compare/MP-2683_combo_page_routes_update?expand=1
Open if you have other option in mind.
There was a problem hiding this comment.
For this one, I was just thinking about how to handle internal to ui links routing to lend/filter. We want to make sure it causes a full page navigation. Probably just removing it like you have here will do that though ;)
3 participants
