Skip to content

Add default tester autocomplete modal#4353

Open
M4dotsuki wants to merge 4 commits into
kiwitcms:masterfrom
M4dotsuki:codex/kiwi-default-tester-autocomplete
Open

Add default tester autocomplete modal#4353
M4dotsuki wants to merge 4 commits into
kiwitcms:masterfrom
M4dotsuki:codex/kiwi-default-tester-autocomplete

Conversation

@M4dotsuki

Copy link
Copy Markdown

Summary

  • add a modal-based bulk default tester picker that uses the existing typeahead.js + JSON-RPC stack
  • call User.filter only for users with auth.view_user; users without that permission keep the existing prompt flow
  • reset the modal input between opens and initialize typeahead only once
  • support autocomplete lookups by username, email, or numeric user ID

Fixes #2510

Validation

  • npx eslint testplans/static/testplans/js/get.js
  • npx webpack

@atodorov atodorov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are willing to work on this we need to resolve comments on older contributions first, then build on top of that, not starting everything from scratch.

Let me know if you are willing to follow up on it and I'll make some adjustments to unblock your work.


</div>

<div class="modal fade" id="default-tester-modal" tabindex="-1" role="dialog"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to duplicate of
#3250.

Can you explain what's the relationship of your code with the previous contribution outlined above ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFE: Show drop down w/ auto-complete for user selection in Test Run Page

2 participants