fix: make ctxFact gob encoding deterministic#31
Draft
DerekTBrown wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctxFactWhy
ctxFactis exported as a Go analysis fact. Raw gob encoding ofmap[string]resInfocan produce different byte streams for the same fact, which is problematic for Bazel/rules_gonogo.factsoutputs and content-addressed caches.Fixes #30
Validation
Red/green evidence:
origin/master/v1.1.6at6e20d9954cd54de0d21c93ddc3b98d1fb0493187: standalone regression test failed withgob encoding changed on iteration 06939d14b5a5f7da390bf88d2c68bf193e94088b2: same standalone regression test passedExisting validation:
go test -run 'TestCtxFactGob' -count=1 -vgo test ./...go test -run TestCtxFactGobEncodingIsDeterministic -count=50