Conversation
…ehaviors)
Acceptance:
- Flip docs/promotions/P0007 promotion_status: proposed -> accepted
- Update tags array ("proposed" -> "accepted")
- Fill Review Notes with operator decision (klappy, 2026-05-05)
Execution:
- canon/constraints/definition-of-done.md: append new section
"## Spec DoD Convention — Agent-Observable Behaviors" before
the project-status marker "## ✅ Status"
- Section requires spec DoD entries to be 5–7 sentences in the form
"<consumer> can <action> and observe <outcome>", not implementation
milestones; gives Allowed / Disallowed examples and Failure Mode
Spec-side complement to P0001's runtime rule. Fourth of 8 stuck proposals.
Previous: P0009 (#167), P0001 (#168), P0008 (#169). Next: P0006 (vodka
boundary enumeration as spec convention).
Canon Quality —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Combined acceptance + execution of promotion P0007 — adds a spec-shape constraint to Definition of Done.
Acceptance (1 file)
docs/promotions/P0007-dod-as-agent-observable-behaviors.mdpromotion_status: proposed→accepted"proposed"→"accepted"accepted(2026-05-05)Execution (1 file, +37 lines)
canon/constraints/definition-of-done.md— new section before the project-status marker## ✅ Status:## Spec DoD Convention — Agent-Observable Behaviors"<consumer> can <action> and observe <outcome>"SessionDO class lands at...,wrangler.toml updated...,All tests pass)How this complements P0001
Both touch
canon/constraints/definition-of-done.mdbut at different locations (P0001 →## Operating Constraints+## Failure Modes; P0007 → new appended section). They auto-merge cleanly regardless of merge order.Position in the 8-proposal sweep
DoD
promotion_statusflippedNote
Low Risk
Low risk: documentation-only updates that clarify spec-writing conventions without changing runtime behavior or requiring migration.
Overview
Introduces a new Spec DoD convention in
canon/constraints/definition-of-done.mdrequiring spec Definition of Done sections to be phrased as 5–7 consumer/agent-observable behaviors (with a fixed sentence format, allowed/disallowed examples, and rationale/receipts).Updates
docs/promotions/P0007-dod-as-agent-observable-behaviors.mdto accepted status (tags/frontmatter), and fills in the acceptance record (date and reviewer decision).Reviewed by Cursor Bugbot for commit 49d9ba0. Bugbot is set up for automated code reviews on this repo. Configure here.