Merged
Conversation
…o fix/redirect-mode
isaacwallace123
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
kleff-panelclient always hasstandardFlowEnabled, wildcard redirect URIs, and web origins set — both on first install and on updates to existing clientsRelated Issues
Closes #
Changes
What's Included
internal/adapters/keycloak/client.go—EnsureRealmnow creates/updates thekleff-panelclient withstandardFlowEnabled: true,redirectUris: ["*"], andwebOrigins: ["*"]; added PUT update path for when the client already exists (previously only CREATE was handled, leaving stale config on reinstall)What's Not Included
*for self-hosted dev; production hardening is out of scope)directAccessGrantsEnabledremains trueTesting
How Was This Tested?
AUTH_MODE=redirect, verified Keycloak login page loads and redirect back tolocalhost:3000/auth/callbacksucceedsEnsureRealmand correctly updates the existing clientTest Coverage
Breaking Changes
Does this PR introduce breaking changes?
Headless mode (
directAccessGrantsEnabled) is preserved. The only change is enabling the standard flow that was previously blocked.Security Considerations
redirectUris: ["*"]is a wildcard. This is acceptable for a self-hosted development tool but should be tightened in a production-hardened deployment. No change to token validation logic.Documentation
Does this PR require documentation updates?
UI/UX (If Applicable)
N/A — backend only.
Pre-Merge Checklist
feat:,fix:,chore:,docs:,refactor:,test:)Reviewer Notes