Merged
Conversation
isaacwallace123
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
EnsureAdminerrors up throughEnsureRealmso the startup retry loop keeps retrying until the admin user actually existsKEYCLOAK_PUBLIC_URLandAUTH_MODEconfig fields to advanced settings to reduce noise for typical deploymentsRelated Issues
Closes #
Changes
What's Included
client.go:EnsureAdminfailure now returnsfmt.Errorf("ensure admin: %w", err)fromEnsureRealminstead of being silently swallowed — this keepsready: falseon the platform side until the admin user is created and reachablekleff-plugin.json:KEYCLOAK_PUBLIC_URLandAUTH_MODEmarkedadvanced: trueso the setup form only shows the essential fields by defaultWhat's Not Included
EnsureRealmcompletes)Testing
How Was This Tested?
Public URLandLogin Modeunder "Show advanced settings"Test Coverage
Breaking Changes
Does this PR introduce breaking changes?
Security Considerations
Ensures the admin account is confirmed to exist before the platform marks the IDP as ready. Previously, a transient
EnsureAdminfailure would be silently ignored, leaving the IDP "ready" with no admin account.Documentation
Does this PR require documentation updates?
UI/UX (If Applicable)
Advanced config fields are now hidden by default behind the "Show advanced settings" toggle.
Pre-Merge Checklist
fix: propagate EnsureAdmin error to keep loading until admin exists)Reviewer Notes
Before this fix: if
EnsureAdminfailed (e.g. Keycloak API rate-limited the request), the error was printed and discarded.EnsureRealmreturnednil, gRPC started, and the platform setready: true— but no admin user existed yet. The user would see the login form, try logging in, and get a 401.