Skip to content

bugfix(KLEF): Use PR flow to bump kleff-plugin.json on release#6

Merged
isaacwallace123 merged 1 commit intomainfrom
fix/release-branch-protection
Apr 2, 2026
Merged

bugfix(KLEF): Use PR flow to bump kleff-plugin.json on release#6
isaacwallace123 merged 1 commit intomainfrom
fix/release-branch-protection

Conversation

@JeremyNRoos
Copy link
Copy Markdown
Contributor

Pull Request

Summary

  • Fixes release workflow failing to push version bump directly to main due to branch protection rules
  • Replaces direct git push origin HEAD:main with the same GitHub App PR + auto-merge pattern already used for the plugin-registry bump

Related Issues

No related issue — release was broken immediately after the auto-version-bump feature was merged.


Changes

What's Included

  • release.yml: replaced direct push step with a GitHub Script step that creates a branch, commits the kleff-plugin.json version bump, opens a PR, and auto-merges it using the existing KLEFF_APP_ID / KLEFF_APP_PRIVATE_KEY app token
  • release.yml: added Generate app token for self step to get a token scoped to keycloak-plugin

What's Not Included

  • Changes to branch protection rules
  • Changes to the registry auto-PR step (unaffected)

Testing

How Was This Tested?

  • To be verified on next tag push

Test Coverage

  • Unit tests added or updated
  • Integration tests added or updated
  • Manually tested end-to-end

Breaking Changes

Does this PR introduce breaking changes?

  • Yes
  • No

Security Considerations

  • This PR affects authentication or authorization logic
  • This PR touches secrets, tokens, or environment variables
  • This PR affects infrastructure, deployment pipelines, or network configuration

Uses the existing GitHub App (KLEFF_APP_ID / KLEFF_APP_PRIVATE_KEY) scoped to keycloak-plugin. No new secrets introduced. The app token is short-lived and generated per-run.


Documentation

Does this PR require documentation updates?

  • Yes
  • No

UI/UX (If Applicable)

N/A


Pre-Merge Checklist

  • PR title follows semantic format (fix: use PR flow to bump kleff-plugin.json on release)
  • All CI checks passing
  • No debug logs or commented-out code left in
  • No sensitive information included

Reviewer Notes

@JeremyNRoos JeremyNRoos changed the title fix: use PR flow to bump kleff-plugin.json on release bugfix(KLEF): Use PR flow to bump kleff-plugin.json on release Apr 2, 2026
@isaacwallace123 isaacwallace123 merged commit a110ccf into main Apr 2, 2026
1 check passed
@isaacwallace123 isaacwallace123 deleted the fix/release-branch-protection branch April 2, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants