Skip to content

bugfix(KLEF): Use plugin.json as source of truth#7

Merged
isaacwallace123 merged 1 commit intomainfrom
fix/remove-self-version-bump
Apr 2, 2026
Merged

bugfix(KLEF): Use plugin.json as source of truth#7
isaacwallace123 merged 1 commit intomainfrom
fix/remove-self-version-bump

Conversation

@JeremyNRoos
Copy link
Copy Markdown
Contributor

Pull Request

Summary

  • Removes the kleff-plugin.json auto-version-bump step from the release workflow
  • The step was failing because the GitHub App is not installed on this repo, and GITHUB_TOKEN cannot merge PRs on protected branches
  • kleff-plugin.json version is a nice-to-have; plugins.json in the registry is the source of truth the platform reads

Related Issues

No related issue — unblocks the release workflow from completing successfully.


Changes

What's Included

  • release.yml: removed Generate app token for self and Bump version in kleff-plugin.json steps
  • release.yml: reverted contents permission back to read

What's Not Included

  • Auto-bumping kleff-plugin.json — this will be done manually as part of plugin PRs

Testing

How Was This Tested?

  • Verified on next tag push after merge

Test Coverage

  • Unit tests added or updated
  • Integration tests added or updated
  • Manually tested end-to-end

Breaking Changes

Does this PR introduce breaking changes?

  • Yes
  • No

Security Considerations

  • This PR affects authentication or authorization logic
  • This PR touches secrets, tokens, or environment variables
  • This PR affects infrastructure, deployment pipelines, or network configuration

Reduces permissions — contents downgraded from write back to read.


Documentation

Does this PR require documentation updates?

  • Yes
  • No

UI/UX (If Applicable)

N/A


Pre-Merge Checklist

  • PR title follows semantic format (fix: remove self-version-bump from release workflow)
  • All CI checks passing
  • No debug logs or commented-out code left in
  • No sensitive information included

Reviewer Notes

@JeremyNRoos JeremyNRoos self-assigned this Apr 2, 2026
@JeremyNRoos JeremyNRoos changed the title fix(KLEF): Use plugin.json as source of truth bugfix(KLEF): Use plugin.json as source of truth Apr 2, 2026
@JeremyNRoos JeremyNRoos added the bug Something isn't working label Apr 2, 2026
@isaacwallace123 isaacwallace123 merged commit b838db0 into main Apr 2, 2026
1 check passed
@isaacwallace123 isaacwallace123 deleted the fix/remove-self-version-bump branch April 2, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants