Skip to content

added page slot names#1

Merged
isaacwallace123 merged 2 commits intomainfrom
feat/KLEF-118-Add_Page_Slot_Names
Apr 2, 2026
Merged

added page slot names#1
isaacwallace123 merged 2 commits intomainfrom
feat/KLEF-118-Add_Page_Slot_Names

Conversation

@NathanRoos
Copy link
Copy Markdown
Contributor

Pull Request

Summary

Expands the SlotName type to cover every injectable and overridable slot across all panel pages, giving plugin developers a complete, typed surface to target.

Related Issues

Closes #


Changes

What's Included

  • Added page-level slots for dashboard, servers, billing, settings, and admin (top/bottom injection points, header, content sections)
  • Added PluginWrapper-specific slots: dashboard.header, billing.header, admin.header, settings.header, admin.cards
  • Fixed page slot comment (path no longer prefixed with /p/)

What's Not Included


Testing

How Was This Tested?

Panel built successfully against the updated SDK with no TypeScript errors on any of the new slot names
plugin-hello registered components into dashboard.metrics, servers.list, billing.plan, and admin.metrics — all resolved correctly at runtime
All existing slots (navbar.item, page, topbar.right, global.provider, settings.section, dashboard.widget) remain unchanged and unaffected

Test Coverage

  • Unit tests added or updated
  • Integration tests added or updated
  • Manually tested end-to-end

Breaking Changes

Does this PR introduce breaking changes?

  • Yes
  • No

If yes, describe the impact and any required migration steps:


Security Considerations

  • This PR affects authentication or authorization logic
  • This PR touches secrets, tokens, or environment variables
  • This PR affects infrastructure, deployment pipelines, or network configuration

If any box is checked, describe the security impact and any mitigations applied:


Documentation

Does this PR require documentation updates?

  • Yes
  • No

If yes, check all that apply:

  • README.md
  • ARCHITECTURE.md
  • API reference
  • Architecture diagrams (C4 / DDD)
  • /docs

UI/UX (If Applicable)

  • Includes new components or views
  • Changes styles or theme tokens
  • Responsive behavior verified
  • Requires design approval

Screenshots or recordings:


Pre-Merge Checklist

  • PR title follows semantic format (feat:, fix:, chore:, docs:, refactor:, test:)
  • All CI checks passing
  • Code follows project style guidelines
  • No debug logs or commented-out code left in
  • Dependencies reviewed (no unnecessary additions)
  • No sensitive information included

Reviewer Notes

@NathanRoos NathanRoos self-assigned this Apr 2, 2026
@NathanRoos NathanRoos added the enhancement New feature or request label Apr 2, 2026
@isaacwallace123 isaacwallace123 merged commit c3e2fa1 into main Apr 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants