[WIP] POC: Add Kafka middleware package#169
Open
aliok wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aliok The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: THIS IS A POC. Do not review the whole thing, but review the overall structure and the integration points.
Add a new
kafka/package that implements a Functions Kafka middleware,following the same patterns as the existing
http/andcloudevents/packages.The middleware runs a sarama consumer group alongside an HTTP health server,
delivering raw messages (key, value, headers) to the user's Handle method.
Offset is committed on success; errors are logged and skipped (for the initial impl's sake).
Example usage is in
cmd/fkafka/Delivery semantics:
This work is part of the ongoing effort to support Kafka in the Functions. Related: knative/func#3923