Skip to content

[WIP] POC: Add Kafka middleware package#169

Open
aliok wants to merge 1 commit into
knative-extensions:mainfrom
aliok:add-kafka-middleware
Open

[WIP] POC: Add Kafka middleware package#169
aliok wants to merge 1 commit into
knative-extensions:mainfrom
aliok:add-kafka-middleware

Conversation

@aliok

@aliok aliok commented Jun 25, 2026

Copy link
Copy Markdown
Member

NOTE: THIS IS A POC. Do not review the whole thing, but review the overall structure and the integration points.

Add a new kafka/ package that implements a Functions Kafka middleware,
following the same patterns as the existing http/ and cloudevents/ packages.

The middleware runs a sarama consumer group alongside an HTTP health server,
delivering raw messages (key, value, headers) to the user's Handle method.
Offset is committed on success; errors are logged and skipped (for the initial impl's sake).

Example usage is in cmd/fkafka/

Delivery semantics:

  • At-least-once, in-order per partition
  • No retry or deduplication yet (tracked as TODOs)

This work is part of the ongoing effort to support Kafka in the Functions. Related: knative/func#3923

@knative-prow knative-prow Bot requested review from matejvasek and matzew June 25, 2026 14:43
@knative-prow

knative-prow Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok
Once this PR has been reviewed and has the lgtm label, please assign lkingland for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 25, 2026
@aliok aliok changed the title Add Kafka middleware package [WIP] POC: Add Kafka middleware package Jun 25, 2026
@knative-prow knative-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant