Skip to content

fix: guard against empty Build.Image in ImageNameWithDigest #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elvand-Lie wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −0
Open

fix: guard against empty Build.Image in ImageNameWithDigest #3905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d25107
fix: guard against empty Build.Image in ImageNameWithDigest
Elvand-Lie Jun 17, 2026
8fd22ba
test image digest with empty image
Elvand-Lie Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/functions/function.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,6 +862,9 @@ func (f Function) ImageNameWithDigest(newDigest string) string {
return f.Build.Image
}
image := f.Build.Image
if image == "" {
return ""
}
Comment on lines 864 to +867

// overwrite current digest
shaIndex := strings.Index(image, "@sha256:")
Expand Down
5 changes: 5 additions & 0 deletions pkg/functions/function_unit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ func TestFunction_ImageWithDigest(t *testing.T) {
fields: fields{Image: "image-registry.openshift-image-registry.svc.cluster.local:50000/default/bar@sha256:42", ImageDigest: ""},
want: "image-registry.openshift-image-registry.svc.cluster.local:50000/default/bar@sha256:42",
},
{
name: "Empty image with digest",
fields: fields{Image: "", ImageDigest: "sha256:42"},
want: "",
},
}
//TODO: gauron99 - this is gonna need to be changed (probably) because:
// 1: imageDigest now doesn't have a dedicated structure member (resolved?)
Expand Down
Loading